From 3d1cd3b58f9db4a89edf83cd7771a7fb052249dd Mon Sep 17 00:00:00 2001 From: Chuck Lantz Date: Thu, 18 Feb 2021 15:31:14 +0000 Subject: [PATCH] Refresh comments in dev container --- .devcontainer/Dockerfile | 8 +++++--- .devcontainer/devcontainer.json | 12 ++++++------ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 89656e2..0863282 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -1,5 +1,7 @@ -# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.134.0/containers/javascript-node/.devcontainer/base.Dockerfile -ARG VARIANT="14" +# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.159.0/containers/javascript-node/.devcontainer/base.Dockerfile + +# [Choice] Node.js version: 14, 12, 10 +ARG VARIANT="14-buster" FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT} # [Optional] Uncomment this section to install additional OS packages. @@ -11,4 +13,4 @@ FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT} # RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}" # [Optional] Uncomment if you want to install more global node modules -# RUN sudo -u node npm install -g +# RUN su node -c "npm install -g " diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 97635d8..3317773 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,11 +1,11 @@ -// For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at: -// https://github.com/microsoft/vscode-dev-containers/tree/v0.134.0/containers/javascript-node +// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at: +// https://github.com/microsoft/vscode-dev-containers/tree/v0.159.0/containers/javascript-node { "name": "Node.js", "build": { "dockerfile": "Dockerfile", // Update 'VARIANT' to pick a Node version: 10, 12, 14 - "args": { "VARIANT": "12" } + "args": { "VARIANT": "14" } }, // Set *default* container specific settings.json values on container create. @@ -17,13 +17,13 @@ "extensions": [ "dbaeumer.vscode-eslint" ], - + // Use 'forwardPorts' to make a list of ports inside the container available locally. // "forwardPorts": [3000], - // Specifies a command that should be run after the container has been created. + // Use 'postCreateCommand' to run commands after the container is created. "postCreateCommand": "yarn install", - // Comment out the next line to run as root instead. + // Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root. "remoteUser": "node" }