From a8a25f8a10bf15091a9afa3cbd4e47bffeef2cc1 Mon Sep 17 00:00:00 2001
From: bamurtaugh <brmurtau@microsoft.com>
Date: Fri, 16 Apr 2021 20:16:19 +0000
Subject: [PATCH] Update port info, Pylance

---
 .devcontainer/devcontainer.json | 16 ++++++++++++----
 README.md                       |  4 ++--
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index 4228328..e96e675 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -18,6 +18,7 @@
 	"settings": { 
 		"terminal.integrated.shell.linux": "/bin/bash",
 		"python.pythonPath": "/usr/local/bin/python",
+		"python.languageServer": "Pylance",
 		"python.linting.enabled": true,
 		"python.linting.pylintEnabled": true,
 		"python.formatting.autopep8Path": "/usr/local/py-utils/bin/autopep8",
@@ -33,16 +34,15 @@
 
 	// Add the IDs of extensions you want installed when the container is created.
 	"extensions": [
-		"ms-python.python"
+		"ms-python.python",
+		"ms-python.vscode-pylance"
 	],
 
 	// Use 'forwardPorts' to make a list of ports inside the container available locally.
 	// "forwardPorts": [9000],
 
-	// Use 'postCreateCommand' to run commands after the container is created.
-	"postCreateCommand": "pip3 install -r requirements.txt",
-
 	// Use 'portsAttributes' to set default properties for specific forwarded ports.
+	// You can use a port number (i.e. 3000), range of numbers, or a regex to match the running process.
 	"portsAttributes": {
 		"9000": {
 			"label": "Hello Remote World",
@@ -50,6 +50,14 @@
 		}
 	},
 
+	// Use 'otherPortsAttributes' to configure any ports that aren't configured using 'portsAttributes'.
+	// "otherPortsAttributes": {
+	// 		"onAutoForward": "silent"
+	// },
+
+	// Use 'postCreateCommand' to run commands after the container is created.
+	"postCreateCommand": "pip3 install -r requirements.txt",
+
 	// Comment out to connect as root instead.
 	"remoteUser": "vscode"
 }
diff --git a/README.md b/README.md
index 661f47b..c496283 100644
--- a/README.md
+++ b/README.md
@@ -68,12 +68,12 @@ Some things to try:
 
    You may want to make changes to your container, such as installing a different version of a software or forwarding a new port. You'll rebuild your container for your changes to take effect. 
 
-   **Forward a port statically:** As an example change, let's forward a port statically in the `.devcontainer/devcontainer.json` file. 
+   **Open browser automatically:** As an example change, let's update the `portsAttributes` in the `.devcontainer/devcontainer.json` file to open a browser when our port is automatically forwarded.
 
    > **Note:** Remote-Containers and Codespaces also take care of dynamic port forwarding, but there may be instances in which we want to statically declare a forwarded port. 
    
    - Open the `.devcontainer/devcontainer.json` file.
-   - Uncomment the `forwardedPorts` attribute and adjust the port number as needed.
+   - Modify the `"onAutoForward"` attribute in your `portsAttributes` to `"openBrowser"`.
    - Press <kbd>F1</kbd> and select the **Remote-Containers: Rebuild Container** or **Codespaces: Rebuild Container** command so the modifications are picked up.  
 
 ### More samples