From 67e233b925a64f90a46092879ed82b9e6d89f19e Mon Sep 17 00:00:00 2001 From: Chuck Lantz Date: Fri, 13 Aug 2021 16:14:28 +0000 Subject: [PATCH] Bump to 0.191.0 --- .devcontainer/Dockerfile | 9 ++++----- .devcontainer/devcontainer.json | 3 +-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index be73704..9be5a40 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -1,13 +1,12 @@ -# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.185.0/containers/php/.devcontainer/base.Dockerfile +# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.191.0/containers/php/.devcontainer/base.Dockerfile # [Choice] PHP version: 8, 8.0, 7, 7.4, 7.3 ARG VARIANT="7" FROM mcr.microsoft.com/vscode/devcontainers/php:0-${VARIANT} -# [Option] Install Node.js -ARG INSTALL_NODE="true" -ARG NODE_VERSION="lts/*" -RUN if [ "${INSTALL_NODE}" = "true" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi +# [Choice] Node.js version: none, lts/*, 16, 14, 12, 10 +ARG NODE_VERSION="none" +RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi # [Optional] Uncomment this section to install additional OS packages. # RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 1a180a0..a148f23 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,5 +1,5 @@ // For format details, see https://aka.ms/devcontainer.json. For config options, see the README at: -// https://github.com/microsoft/vscode-dev-containers/tree/v0.185.0/containers/php +// https://github.com/microsoft/vscode-dev-containers/tree/v0.191.0/containers/php { "name": "PHP", "build": { @@ -7,7 +7,6 @@ "args": { // Update VARIANT to pick a PHP version: 8, 8.0, 7, 7.4, 7.3 "VARIANT": "7", - "INSTALL_NODE": "true", "NODE_VERSION": "lts/*" } },